Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.14] handler: Retry nncp status updated on error #536

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

[4.14] handler: Retry nncp status updated on error #536

wants to merge 1 commit into from

Conversation

mkowalski
Copy link

Cherry-picks 23f88eb

@qinqon @mkowalski
handler: Retry nncp status updated on error (nmstate#1269)
ea1d81b 
At node reboot the NNCP get re-apply but nmstate-webhook may not be
ready so it fails, this change add a retry on error at nncp status
update to prevent this. Not that Reconcile cycle is not call since this
is done at a "defer" call.

Signed-off-by: Enrique Llorente <[email protected]>
@openshift-ci openshift-ci bot requested review from qinqon and RamLavi October 10, 2024 06:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@mkowalski
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 10, 2024

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-handler-ovn-ipv4 ea1d81b link true /test e2e-handler-ovn-ipv4
ci/prow/e2e-operator-ovn-ipv4 ea1d81b link true /test e2e-operator-ovn-ipv4
ci/prow/security ea1d81b link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qinqon
Copy link

qinqon commented Nov 26, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon Awaiting requested review from qinqon

@RamLavi RamLavi Awaiting requested review from RamLavi

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkowalski @qinqon